dbrun/blowfish
1
0
Fork 0
mirror of https://github.com/nunocoracao/blowfish.git synced 2026-01-30 16:31:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

♻️ Refactor: Move 2 inline event handlers out of line

Browse Source 
If MDN explicitly warns user not to use them, we probably shouldn't.

MDN also states: "Note that inline event handlers are blocked as well[...]You should replace them with addEventListener calls[...]" regarding CSP.
This commit is contained in:
Served Smart
2025-06-18 22:50:12 +02:00
parent a9aae948eb
commit a34947a630
5 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
assets/js/button-likes.js Normal file
View File

@@ -0,0 +1,4 @@
document.getElementById("button_likes") &&
document.getElementById("button_likes").addEventListener("click", () => {
process_article();
});

4
assets/js/katex-render.js Normal file
View File

@@ -0,0 +1,4 @@
document.getElementById("katex-render") &&
document.getElementById("katex-render").addEventListener("load", () => {
renderMathInElement(document.body);
});

4
layouts/partials/head.html
View File

@@ -68,6 +68,10 @@
{{ end }} {{ end }}
{{ $jsMobileMenu := resources.Get "js/mobilemenu.js" }} {{ $jsMobileMenu := resources.Get "js/mobilemenu.js" }}
{{ $assets.Add "js" (slice $jsMobileMenu) }} {{ $assets.Add "js" (slice $jsMobileMenu) }}
{{ $buttonLikes := resources.Get "js/button-likes.js" }}
{{ $assets.Add "js" (slice $buttonLikes) }}
{{ $katexRender := resources.Get "js/katex-render.js" }}
{{ $assets.Add "js" (slice $katexRender) }}
{{ if $assets.Get "js" }} {{ if $assets.Get "js" }}
{{ $bundleJS := $assets.Get "js" | resources.Concat "js/main.bundle.js" | resources.Minify | resources.Fingerprint {{ $bundleJS := $assets.Get "js" | resources.Concat "js/main.bundle.js" | resources.Minify | resources.Fingerprint
(.Site.Params.fingerprintAlgorithm | default "sha512") }} (.Site.Params.fingerprintAlgorithm | default "sha512") }}

3
layouts/partials/meta/likes_button.html
View File

@@ -1,8 +1,7 @@
<span> <span>
<button <button
id="button_likes" id="button_likes"
class="rounded-md border border-primary-400 px-1 py-[1px] text-xs font-normal text-primary-700 dark:border-primary-600 dark:text-primary-400" class="rounded-md border border-primary-400 px-1 py-[1px] text-xs font-normal text-primary-700 dark:border-primary-600 dark:text-primary-400">
onclick="process_article()">
<span id="button_likes_heart" class="inline-block align-text-bottom hidden" <span id="button_likes_heart" class="inline-block align-text-bottom hidden"
>{{ partial "icon.html" "heart" }} >{{ partial "icon.html" "heart" }}
</span> </span>

15
layouts/partials/vendor.html
View File

@@ -37,16 +37,15 @@
rel="stylesheet" rel="stylesheet"
href="{{ $katexCSS.RelPermalink }}" href="{{ $katexCSS.RelPermalink }}"
integrity="{{ $katexCSS.Data.Integrity }}"> integrity="{{ $katexCSS.Data.Integrity }}">
{{ $katexJS := resources.Get "lib/katex/katex.min.js" }} {{ $katexLib := resources.Get "lib/katex/katex.min.js" }}
{{ $katexJS := $katexJS | resources.Fingerprint (.Site.Params.fingerprintAlgorithm | default "sha512") }} {{ $katexRenderLib := resources.Get "lib/katex/auto-render.min.js" }}
<script defer src="{{ $katexJS.RelPermalink }}" integrity="{{ $katexJS.Data.Integrity }}"></script> {{ $katexJS := slice $katexLib $katexRenderLib | resources.Concat "js/katex.bundle.js" | resources.Fingerprint (.Site.Params.fingerprintAlgorithm | default "sha512") }}
{{ $katexRenderJS := resources.Get "lib/katex/auto-render.min.js" }}
{{ $katexRenderJS := $katexRenderJS | resources.Fingerprint (.Site.Params.fingerprintAlgorithm | default "sha512") }}
<script <script
defer defer
src="{{ $katexRenderJS.RelPermalink }}" type="text/javascript"
integrity="{{ $katexRenderJS.Data.Integrity }}" src="{{ $katexJS.RelPermalink }}"
onload="renderMathInElement(document.body);"></script> integrity="{{ $katexJS.Data.Integrity }}"
id="katex-render"></script>
{{ $katexFonts := resources.Match "lib/katex/fonts/*" }} {{ $katexFonts := resources.Match "lib/katex/fonts/*" }}
{{ range $katexFonts }} {{ range $katexFonts }}
<!-- {{ .RelPermalink }} --> <!-- {{ .RelPermalink }} -->