From 7cb8dcc4a1d3bcc441a1c263759a9cf02f87232d Mon Sep 17 00:00:00 2001
From: ZhenShuo Leo <98386542+ZhenShuo2021@users.noreply.github.com>
Date: Thu, 18 Sep 2025 03:50:35 +0800
Subject: [PATCH] chore(article-link): remove _external-link.html

we don't need this anymore
---
 layouts/partials/article-link/_external-link.html | 5 -----
 layouts/partials/article-link/_shortcode.html     | 6 +++++-
 layouts/partials/article-link/card-related.html   | 6 +++++-
 layouts/partials/article-link/card.html           | 6 +++++-
 layouts/partials/article-link/simple.html         | 9 ++++++---
 5 files changed, 21 insertions(+), 11 deletions(-)
 delete mode 100644 layouts/partials/article-link/_external-link.html

diff --git a/layouts/partials/article-link/_external-link.html b/layouts/partials/article-link/_external-link.html
deleted file mode 100644
index e3e9980d..00000000
--- a/layouts/partials/article-link/_external-link.html
+++ /dev/null
@@ -1,5 +0,0 @@
-{{ with .Params.externalUrl }}
-  href="{{ . }}" target="_blank" rel="external"
-{{ else }}
-  href="{{ .RelPermalink }}"
-{{- end -}}
diff --git a/layouts/partials/article-link/_shortcode.html b/layouts/partials/article-link/_shortcode.html
index 511565f0..ef25463e 100644
--- a/layouts/partials/article-link/_shortcode.html
+++ b/layouts/partials/article-link/_shortcode.html
@@ -69,7 +69,11 @@
   <div class="{{ $cardContentClasses }}">
     <header class="items-center text-start text-xl font-semibold">
       <a
-        {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
+        {{ with .Params.externalUrl }}
+          href="{{ . }}" target="_blank" rel="external"
+        {{ else }}
+          href="{{ .RelPermalink }}"
+        {{ end }}
         class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
         <h2>
           {{ $target.Title | emojify }}
diff --git a/layouts/partials/article-link/card-related.html b/layouts/partials/article-link/card-related.html
index 0bb98641..dc0e49af 100644
--- a/layouts/partials/article-link/card-related.html
+++ b/layouts/partials/article-link/card-related.html
@@ -52,7 +52,11 @@
   <div class="px-6 py-4">
     <header>
       <a
-        {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
+        {{ with .Params.externalUrl }}
+          href="{{ . }}" target="_blank" rel="external"
+        {{ else }}
+          href="{{ .RelPermalink }}"
+        {{ end }}
         class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
         <h2>
           {{ .Title | emojify }}
diff --git a/layouts/partials/article-link/card.html b/layouts/partials/article-link/card.html
index aaaab0c8..636741a0 100644
--- a/layouts/partials/article-link/card.html
+++ b/layouts/partials/article-link/card.html
@@ -56,7 +56,11 @@
   <div class="px-6 py-4">
     <header>
       <a
-        {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
+        {{ with .Params.externalUrl }}
+          href="{{ . }}" target="_blank" rel="external"
+        {{ else }}
+          href="{{ .RelPermalink }}"
+        {{ end }}
         class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
         <h2>
           {{ .Title | emojify }}
diff --git a/layouts/partials/article-link/simple.html b/layouts/partials/article-link/simple.html
index 50924907..7b9fa430 100644
--- a/layouts/partials/article-link/simple.html
+++ b/layouts/partials/article-link/simple.html
@@ -56,8 +56,7 @@
 
 <article class="{{ $cardClasses }}">
   {{ with $featuredURL }}
-    <figure
-      class="not-prose flex-none relative overflow-hidden {{ $figureClasses }} thumbnail--simple">
+    <figure class="not-prose flex-none relative overflow-hidden {{ $figureClasses }} thumbnail--simple">
       <img
         src="{{ . }}"
         alt="{{ $.Title }}"
@@ -69,7 +68,11 @@
   <div class="{{ $cardContentClasses }}">
     <header class="items-center text-start text-xl font-semibold">
       <a
-        {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
+        {{ with .Params.externalUrl }}
+          href="{{ . }}" target="_blank" rel="external"
+        {{ else }}
+          href="{{ .RelPermalink }}"
+        {{ end }}
         class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
         <h2>
           {{ .Title | emojify }}