From 5bab41062a7b30c724dd466e8abd38fcbf9a331c Mon Sep 17 00:00:00 2001
From: ZhenShuo Leo <98386542+ZhenShuo2021@users.noreply.github.com>
Date: Sat, 6 Sep 2025 14:55:40 +0800
Subject: [PATCH] refactor(article-link): remove unnecessary with syntax

---
 layouts/partials/article-link/_shortcode.html | 24 +++++++------------
 .../partials/article-link/card-related.html   | 14 ++++-------
 layouts/partials/article-link/card.html       | 14 ++++-------
 layouts/partials/article-link/simple.html     | 14 ++++-------
 4 files changed, 24 insertions(+), 42 deletions(-)

diff --git a/layouts/partials/article-link/_shortcode.html b/layouts/partials/article-link/_shortcode.html
index 8da60d8f..36e9450e 100644
--- a/layouts/partials/article-link/_shortcode.html
+++ b/layouts/partials/article-link/_shortcode.html
@@ -71,21 +71,15 @@
       <a
         {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
         class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
-        {{ with $target.Params.externalUrl }}
-          <div>
-            <div>
-              {{ $target.Title | emojify }}
-              <span class="cursor-default align-top text-xs text-neutral-400 dark:text-neutral-500">
-                <span class="rtl:hidden">&#8599;</span>
-                <span class="ltr:hidden">&#8598;</span>
-              </span>
-            </div>
-          </div>
-        {{ else }}
-          <div>
-            {{ $target.Title | emojify }}
-          </div>
-        {{ end }}
+        <div>
+          {{ $target.Title | emojify }}
+          {{ if $target.Params.externalUrl }}
+            <span class="cursor-default align-top text-xs text-neutral-400 dark:text-neutral-500">
+              <span class="rtl:hidden">&#8599;</span>
+              <span class="ltr:hidden">&#8598;</span>
+            </span>
+          {{ end }}
+        </div>
       </a>
       {{ if and $target.Draft site.Params.article.showDraftLabel }}
         <div class="ms-2">
diff --git a/layouts/partials/article-link/card-related.html b/layouts/partials/article-link/card-related.html
index 2ee56640..5510d4af 100644
--- a/layouts/partials/article-link/card-related.html
+++ b/layouts/partials/article-link/card-related.html
@@ -45,19 +45,15 @@
     <a
       {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
       class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
-      {{ with .Params.externalUrl }}
-        <div>
-          {{ $.Title | emojify }}
+      <div>
+        {{ .Title | emojify }}
+        {{ if .Params.externalUrl }}
           <span class="cursor-default align-top text-xs text-neutral-400 dark:text-neutral-500">
             <span class="rtl:hidden">&#8599;</span>
             <span class="ltr:hidden">&#8598;</span>
           </span>
-        </div>
-      {{ else }}
-        <div>
-          {{ .Title | emojify }}
-        </div>
-      {{ end }}
+        {{ end }}
+      </div>
     </a>
     <div class="text-sm text-neutral-500 dark:text-neutral-400">
       {{ partial "article-meta/basic.html" . }}
diff --git a/layouts/partials/article-link/card.html b/layouts/partials/article-link/card.html
index 00692131..c0927192 100644
--- a/layouts/partials/article-link/card.html
+++ b/layouts/partials/article-link/card.html
@@ -49,19 +49,15 @@
     <a
       {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
       class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
-      {{ with .Params.externalUrl }}
-        <div>
-          {{ $.Title | emojify }}
+      <div>
+        {{ .Title | emojify }}
+        {{ if .Params.externalUrl }}
           <span class="cursor-default align-top text-xs text-neutral-400 dark:text-neutral-500">
             <span class="rtl:hidden">&#8599;</span>
             <span class="ltr:hidden">&#8598;</span>
           </span>
-        </div>
-      {{ else }}
-        <div>
-          {{ .Title | emojify }}
-        </div>
-      {{ end }}
+        {{ end }}
+      </div>
     </a>
     <div class="text-sm text-neutral-500 dark:text-neutral-400">
       {{ partial "article-meta/basic.html" . }}
diff --git a/layouts/partials/article-link/simple.html b/layouts/partials/article-link/simple.html
index cf7a342f..ce087db9 100644
--- a/layouts/partials/article-link/simple.html
+++ b/layouts/partials/article-link/simple.html
@@ -71,19 +71,15 @@
       <a
         {{ partial "article-link/_external-link.html" . | safeHTMLAttr }}
         class="not-prose before:absolute before:inset-0 decoration-primary-500 dark:text-neutral text-xl font-bold text-neutral-800 hover:underline hover:underline-offset-2">
-        {{ with .Params.externalUrl }}
-          <div>
-            {{ $.Title | emojify }}
+        <div>
+          {{ .Title | emojify }}
+          {{ if .Params.externalUrl }}
             <span class="cursor-default align-top text-xs text-neutral-400 dark:text-neutral-500">
               <span class="rtl:hidden">&#8599;</span>
               <span class="ltr:hidden">&#8598;</span>
             </span>
-          </div>
-        {{ else }}
-          <div>
-            {{ .Title | emojify }}
-          </div>
-        {{ end }}
+          {{ end }}
+        </div>
       </a>
       {{ if and .Draft .Site.Params.article.showDraftLabel }}
         <div class="ms-2">{{ partial "badge.html" (i18n "article.draft" | emojify) }}</div>